Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760564Ab2FDNOb (ORCPT ); Mon, 4 Jun 2012 09:14:31 -0400 Received: from mail-gg0-f174.google.com ([209.85.161.174]:33556 "EHLO mail-gg0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753391Ab2FDNO3 convert rfc822-to-8bit (ORCPT ); Mon, 4 Jun 2012 09:14:29 -0400 MIME-Version: 1.0 In-Reply-To: <20120604125356.GB7738@localhost> References: <1338813642-6476-1-git-send-email-liwp.linux@gmail.com> <20120604125356.GB7738@localhost> Date: Mon, 4 Jun 2012 22:14:28 +0900 Message-ID: Subject: Re: [PATCH] remove no longer use of pdflush interface From: Minchan Kim To: Fengguang Wu Cc: Wanpeng Li , Alexander Viro , Jan Kara , Andrew Morton , Mel Gorman , "Eric W. Biederman" , David Howells , James Morris , Ingo Molnar , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Wanpeng Li Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1048 Lines: 29 On Mon, Jun 4, 2012 at 9:53 PM, Fengguang Wu wrote: > Hi Wanpeng, > > On Mon, Jun 04, 2012 at 08:40:42PM +0800, Wanpeng Li wrote: >> From: Wanpeng Li >> >> remove no longer use of pdflush interface nr_pdflush_threads. > > The patch looks good in itself: the nr_pdflush_threads takes no effect > for many of the recent kernels. But what's the normal process of > interface removal?  Shall we carry some warning printk for some time > first or whatever? Yes. you have to add printk warning for noticing it deprecated. And add descriptoin in Documentation/ABI/obsolete/ and Documentation/feature-removal-schedule.txt I don't know how long we maintain it. Is there any rule for it? Maybe 1-year is suitable, IMHO. Thanks. -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/