Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760583Ab2FDNTL (ORCPT ); Mon, 4 Jun 2012 09:19:11 -0400 Received: from www.linutronix.de ([62.245.132.108]:41364 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760416Ab2FDNTJ (ORCPT ); Mon, 4 Jun 2012 09:19:09 -0400 Date: Mon, 4 Jun 2012 15:18:56 +0200 (CEST) From: Thomas Gleixner To: "Srivatsa S. Bhat" cc: Sam Ravnborg , peterz@infradead.org, paulmck@linux.vnet.ibm.com, rusty@rustcorp.com.au, mingo@kernel.org, yong.zhang0@gmail.com, akpm@linux-foundation.org, vatsa@linux.vnet.ibm.com, rjw@sisk.pl, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, nikunj@linux.vnet.ibm.com, Suresh Siddha , Venkatesh Pallipadi Subject: Re: [PATCH 01/27] smpboot: Provide a generic method to boot secondary processors In-Reply-To: <4FCCB31B.6060302@linux.vnet.ibm.com> Message-ID: References: <20120601090952.31979.24799.stgit@srivatsabhat.in.ibm.com> <20120601091008.31979.93586.stgit@srivatsabhat.in.ibm.com> <20120601165113.GA18870@merkur.ravnborg.org> <4FC9424E.9060009@linux.vnet.ibm.com> <4FCCB31B.6060302@linux.vnet.ibm.com> User-Agent: Alpine 2.02 (LFD 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1249 Lines: 32 On Mon, 4 Jun 2012, Srivatsa S. Bhat wrote: > On 06/04/2012 04:02 PM, Thomas Gleixner wrote: > I can add the prototype w/o the __weak prefix and the #ifndef magic in > include/linux/smpboot.h (which I will, and include it in v2). > > However, I can't get rid of the #ifndef magic in kernel/smpboot.c because > it will cause build failures on x86. > > I addressed this same issue in another email: > https://lkml.org/lkml/2012/6/3/33 > In short, to avoid breaking build on x86. > We wanted to follow the x86 convention of having static inline functions in > arch/x86/include/asm/smp.h and use the smp_ops structure to route the calls > to x86 or xen as appropriate (see patch 4 in this series). Oh no. That's not really a good argument. There is no reason why this _must_ be an inline function on x86. It can be a proper function in arch/x86/kernel/smpboot.c as well. The alternative solution is to generalize the smp_ops approach and get rid of the weak implementations completely. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/