Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760983Ab2FDQcy (ORCPT ); Mon, 4 Jun 2012 12:32:54 -0400 Received: from tx2ehsobe002.messaging.microsoft.com ([65.55.88.12]:2533 "EHLO tx2outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760971Ab2FDQcw (ORCPT ); Mon, 4 Jun 2012 12:32:52 -0400 X-Forefront-Antispam-Report: CIP:70.37.183.190;KIP:(null);UIP:(null);IPV:NLI;H:mail.freescale.net;RD:none;EFVD:NLI X-SpamScore: -11 X-BigFish: VS-11(zzbb2dI9371I1432N98dKzz1202hzzz2dh2a8h668h839hd25he5bhf0ah) Message-ID: <4FCCE32F.1060301@freescale.com> Date: Mon, 4 Jun 2012 11:32:47 -0500 From: Scott Wood User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Zhao Chenhui CC: , , , Subject: Re: [PATCH v5 2/5] powerpc/85xx: add HOTPLUG_CPU support References: <1336737235-15370-1-git-send-email-chenhui.zhao@freescale.com> <1336737235-15370-2-git-send-email-chenhui.zhao@freescale.com> <4FC933BF.1020901@freescale.com> <20120604110444.GA20676@localhost.localdomain> In-Reply-To: <20120604110444.GA20676@localhost.localdomain> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 969 Lines: 26 On 06/04/2012 06:04 AM, Zhao Chenhui wrote: > On Fri, Jun 01, 2012 at 04:27:27PM -0500, Scott Wood wrote: >> On 05/11/2012 06:53 AM, Zhao Chenhui wrote: >>> -#ifdef CONFIG_KEXEC >>> +#if defined(CONFIG_KEXEC) || defined(CONFIG_HOTPLUG_CPU) >> >> Let's not grow lists like this. Is there any harm in building it >> unconditionally? >> >> -Scott > > We need this ifdef. We only set give_timebase/take_timebase > when CONFIG_KEXEC or CONFIG_HOTPLUG_CPU is defined. If we really need this to be a compile-time decision, make a new symbol for it, but I really think this should be decided at runtime. Just because we have kexec or hotplug support enabled doesn't mean that's actually what we're doing at the moment. -Scott -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/