Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932515Ab2FDQoe (ORCPT ); Mon, 4 Jun 2012 12:44:34 -0400 Received: from natasha.panasas.com ([67.152.220.90]:42671 "EHLO natasha.panasas.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751989Ab2FDQod (ORCPT ); Mon, 4 Jun 2012 12:44:33 -0400 Message-ID: <4FCCE442.4020801@panasas.com> Date: Mon, 4 Jun 2012 19:37:22 +0300 From: Boaz Harrosh User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111113 Thunderbird/8.0 MIME-Version: 1.0 To: Richard Weinberger CC: Jiri Slaby , Jiri Slaby , , , Jeff Dike , , Al Viro , Subject: Re: [uml-devel] [PATCH 13/24] TTY: um/line, use tty from tty_port References: <1338809738-18967-1-git-send-email-jslaby@suse.cz> <1338809738-18967-14-git-send-email-jslaby@suse.cz> <4FCCA3A6.8080608@nod.at> <4FCCD224.1020307@suse.cz> <4FCCD44A.3090500@nod.at> <4FCCD70D.5010908@suse.cz> <4FCCD774.5040003@nod.at> <4FCCE1D4.7080805@panasas.com> <4FCCE255.4080705@nod.at> In-Reply-To: <4FCCE255.4080705@nod.at> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1192 Lines: 43 On 06/04/2012 07:29 PM, Richard Weinberger wrote: > Am 04.06.2012 18:27, schrieb Boaz Harrosh: >> On 06/04/2012 06:42 PM, Richard Weinberger wrote: >> >>> Am 04.06.2012 17:41, schrieb Jiri Slaby: >>>> Hmm, I remember. I suggest you to split the patch into several pieces. >>>> For example moving the code from ->open into ->install can be done >>>> separately. Otherwise it's hard to tell what's wrong with the patch as >>>> a whole. >>>> >>>> Also, it would be good to see the patch rebased on the top of my >>>> patch, because tty_port_set/get pieces would be gone from your patch too. >>> >>> Okay, I'll redo it! >>> I've a much cleaner version in my local queue. >>> >> >> >> Can you send it my way, I'm still running broken, 3.4 Based ? >> > > Can you please first give Jiri's patches a try? > > [PATCH 12/24] TTY: um/line, add tty_port > [PATCH 13/24] TTY: um/line, use tty from tty_port > OK Will do Boaz > Thanks, > //richard > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/