Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932111Ab2FDTSA (ORCPT ); Mon, 4 Jun 2012 15:18:00 -0400 Received: from smtp.snhosting.dk ([87.238.248.203]:45720 "EHLO smtp.domainteam.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751490Ab2FDTR7 (ORCPT ); Mon, 4 Jun 2012 15:17:59 -0400 Date: Mon, 4 Jun 2012 21:17:57 +0200 From: Sam Ravnborg To: Witold Baryluk Cc: Robert Love , linux-kernel@vger.kernel.org, "James E.J. Bottomley" , devel@open-fcoe.org, linux-scsi@vger.kernel.org Subject: Re: Different WARNING: drivers/scsi/fcoe/libfcoe.o(.init.text+0x1a): Section mismatch in reference from the function init_module() to the function .exit.text:fcoe_transport_exit() Message-ID: <20120604191757.GA21821@merkur.ravnborg.org> References: <20120602161502.GW16584@smp.if.uj.edu.pl> <20120604143643.GJ32472@redhat.com> <20120604163556.GA12303@merkur.ravnborg.org> <20120604190857.GB16584@smp.if.uj.edu.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120604190857.GB16584@smp.if.uj.edu.pl> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1316 Lines: 30 > WARNING: drivers/scsi/fcoe/libfcoe.o(.init.text+0x1a): Section mismatch in reference from the function init_module() to the function .exit.text:fcoe_transport_exit() > The function __init init_module() references > a function __exit fcoe_transport_exit(). > This is often seen when error handling in the init function > uses functionality in the exit path. > The fix is often to remove the __exit annotation of > fcoe_transport_exit() so it may be used outside an exit section. > > CC arch/x86/crypto/crc32c-intel.mod.o > LD [M] arch/x86/crypto/crc32c-intel.ko > CC arch/x86/crypto/salsa20-i586.mod.o > LD [M] arch/x86/crypto/salsa20-i586.ko > CC arch/x86/crypto/serpent-sse2-i586.mod.o > LD [M] arch/x86/crypto/serpent-sse2-i586.ko > > > > (I'm dropping previous CC list, as this warning is easier to solve, > probably just following this instructions - dropping __exit from > fcoe_transport_exit() should be fine, especially if indeed it is needed > from init_module in error path). Correct - dropping __exit is the fix here. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/