Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757342Ab2FDT5K (ORCPT ); Mon, 4 Jun 2012 15:57:10 -0400 Received: from www.linutronix.de ([62.245.132.108]:42949 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752592Ab2FDT5H (ORCPT ); Mon, 4 Jun 2012 15:57:07 -0400 Date: Mon, 4 Jun 2012 21:57:01 +0200 (CEST) From: Thomas Gleixner To: "Luck, Tony" cc: Chen Gong , LKML , "bp@amd64.org" , "x86@kernel.org" , Peter Zijlstra Subject: RE: [patch 1/2] x86: mce Cleanup timer mess In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F192F7E3F@ORSMSX104.amr.corp.intel.com> Message-ID: References: <20120524174943.989990966@linutronix.de> <20120524175056.391516712@linutronix.de> <4FCC1BE4.3070404@linux.intel.com> <3908561D78D1C84285E8C5FCA982C28F192F7E3F@ORSMSX104.amr.corp.intel.com> User-Agent: Alpine 2.02 (LFD 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 803 Lines: 17 On Mon, 4 Jun 2012, Luck, Tony wrote: > > Here Thomas changed original mode from "*n = max(*n/2, HZ/100);" > > to "iv = max(iv, (unsigned long) HZ/100);", which means *iv* will not > > be decremented but only incremented in _else_ branch. If so, eventually > > the *iv will be equal to *check_interval*. I don't think it makes sense. > > It looks like Thomas just forgot the "/ 2" there while cleaning up. > I didn't see it either, nor did Boris when he acked it. Thank goodness > for your extra eyes looking at this. Uurgh. Chen, thanks for spotting it! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/