Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933935Ab2FELRz (ORCPT ); Tue, 5 Jun 2012 07:17:55 -0400 Received: from db3ehsobe005.messaging.microsoft.com ([213.199.154.143]:52789 "EHLO db3outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752951Ab2FELRx (ORCPT ); Tue, 5 Jun 2012 07:17:53 -0400 X-Forefront-Antispam-Report: CIP:70.37.183.190;KIP:(null);UIP:(null);IPV:NLI;H:mail.freescale.net;RD:none;EFVD:NLI X-SpamScore: -11 X-BigFish: VS-11(zzbb2dI9371I1432N98dKzz1202hzzz2dh2a8h668h839h944hd25hf0ah) Date: Tue, 5 Jun 2012 19:18:23 +0800 From: Zhao Chenhui To: Scott Wood CC: , , , Subject: Re: [PATCH v5 2/5] powerpc/85xx: add HOTPLUG_CPU support Message-ID: <20120605111823.GB22427@localhost.localdomain> References: <1336737235-15370-1-git-send-email-chenhui.zhao@freescale.com> <1336737235-15370-2-git-send-email-chenhui.zhao@freescale.com> <4FC933BF.1020901@freescale.com> <20120604110444.GA20676@localhost.localdomain> <4FCCE32F.1060301@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <4FCCE32F.1060301@freescale.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-OriginatorOrg: freescale.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1206 Lines: 32 On Mon, Jun 04, 2012 at 11:32:47AM -0500, Scott Wood wrote: > On 06/04/2012 06:04 AM, Zhao Chenhui wrote: > > On Fri, Jun 01, 2012 at 04:27:27PM -0500, Scott Wood wrote: > >> On 05/11/2012 06:53 AM, Zhao Chenhui wrote: > >>> -#ifdef CONFIG_KEXEC > >>> +#if defined(CONFIG_KEXEC) || defined(CONFIG_HOTPLUG_CPU) > >> > >> Let's not grow lists like this. Is there any harm in building it > >> unconditionally? > >> > >> -Scott > > > > We need this ifdef. We only set give_timebase/take_timebase > > when CONFIG_KEXEC or CONFIG_HOTPLUG_CPU is defined. > > If we really need this to be a compile-time decision, make a new symbol > for it, but I really think this should be decided at runtime. Just > because we have kexec or hotplug support enabled doesn't mean that's > actually what we're doing at the moment. > > -Scott If user does not enable kexec or hotplug, these codes are redundant. So use CONFIG_KEXEC and CONFIG_HOTPLUG_CPU to gard them. -Chenhui -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/