Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757532Ab2FEMwj (ORCPT ); Tue, 5 Jun 2012 08:52:39 -0400 Received: from smtp4-g21.free.fr ([212.27.42.4]:33843 "EHLO smtp4-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754072Ab2FEMwh (ORCPT ); Tue, 5 Jun 2012 08:52:37 -0400 Message-ID: <4FCE0101.6010908@free.fr> Date: Tue, 05 Jun 2012 14:52:17 +0200 From: Daniel Lezcano User-Agent: Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Glauber Costa CC: Serge Hallyn , kir@parallels.com, Michael@openvz.org, Oleg Nesterov , linux-kernel@vger.kernel.org, Kerrisk , Tejun Heo , cgroups@vger.kernel.org, devel@openvz.org, "Eric W. Biederman" Subject: Re: [Devel] Re: [PATCH] allow a task to join a pid namespace References: <1338816828-25312-1-git-send-email-glommer@parallels.com> <4FCDD315.502@free.fr> <4FCDD346.9090008@parallels.com> <4FCDD8A0.1070608@parallels.com> In-Reply-To: <4FCDD8A0.1070608@parallels.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2392 Lines: 64 On 06/05/2012 12:00 PM, Glauber Costa wrote: > On 06/05/2012 01:37 PM, Glauber Costa wrote: >> On 06/05/2012 01:36 PM, Daniel Lezcano wrote: >>> On 06/04/2012 03:33 PM, Glauber Costa wrote: >>>> Currently, it is possible for a process to join existing >>>> net, uts and ipc namespaces. This patch allows a process to join an >>>> existing pid namespace as well. >>>> >>>> For that to remain sane, some restrictions are made in the calling >>>> process: >>>> >>>> * It needs to be in the parent namespace of the namespace it wants to >>>> jump to >>>> * It needs to sit in its own session and group as a leader. >>>> >>>> The rationale for that, is that people want to trigger actions in a >>>> Container >>>> from the outside. For instance, mainstream linux recently gained the >>>> ability >>>> to safely reboot a container. It would be desirable, however, that >>>> this >>>> action is triggered from an admin in the outside world, very much >>>> like a >>>> power switch in a physical box. >>>> >>>> This would also allow us to connect a console to the container, >>>> provide a >>>> repair mode for setups without networking (or with a broken one), etc. >>> >>> Hi Glauber, >>> >>> I am in favor of this patch but I think the pidns support won't be >>> complete and some corner-cases are not handled. >>> >>> May be you can look at Eric's patchset [1] where, IMO, everything is >>> taken into account. Some of the patches may be already upstream. >>> >>> Thanks >>> -- Daniel >> >> I don't remember seeing such patchset in the mailing lists, but that >> might be my fault, due to traffic... >> >> I'll take a look. If it does what I need, I can just drop this. >> > > Ok. In a quick look, it does not seem to go all the way. This is just > by reading, but your reboot patch, for instance, is unlikely to work > with that, since if it doesn't alter pid->level, things like task > ns_of_pid won't work. > > Running the test scripts I wrote for my testing of that patch also > doesn't seem to produce the expected result: > > after doing setns, the pid won't show up in that namespace. Yes, AFAIR, pid won't show up, you have to do fork-exec. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/