Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752336Ab2FEPOi (ORCPT ); Tue, 5 Jun 2012 11:14:38 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:45005 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751989Ab2FEPOg (ORCPT ); Tue, 5 Jun 2012 11:14:36 -0400 Message-ID: <4FCE2256.7010804@openvz.org> Date: Tue, 05 Jun 2012 19:14:30 +0400 From: Konstantin Khlebnikov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.4) Gecko/20120517 Firefox/10.0.4 Iceape/2.7.4 MIME-Version: 1.0 To: OGAWA Hirofumi CC: Ondrej Zary , Hugh Dickins , Kernel development list , Dave Jones , Hans de Bruin , Linux NFS mailing list , Andrew Morton , =?ISO-8859-1?Q?Toralf_F=F6r?= =?ISO-8859-1?Q?ster?= , richard -rw- weinberger Subject: Re: [bisected commit 0fc9d10] NFS-server corruption with 3.4 References: <201206051116.17711.linux@rainbow-software.org> <4FCE0A83.4050502@openvz.org> <201206051620.47925.linux@rainbow-software.org> <4FCE1D17.1080904@openvz.org> <87zk8h23wn.fsf@devron.myhome.or.jp> In-Reply-To: <87zk8h23wn.fsf@devron.myhome.or.jp> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 793 Lines: 22 OGAWA Hirofumi wrote: > Konstantin Khlebnikov writes: > >> Hmm, very interesting! >> Please try this patch, it must fix the problem and print some numbers to debug. >> > > I think the bug is in radix_tree_for_each_contig(). > > radix_tree_next_slot() returns NULL if the slot was NULL (i.e. there is > hole). But, slot == NULL is not meaning to stop iterate here. Actually, > if slot is NULL, it gets next chunk. > > Bang. Yeah, you are right, I already found this too. Currently I think how to fix this more accurately... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/