Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753987Ab2FFATf (ORCPT ); Tue, 5 Jun 2012 20:19:35 -0400 Received: from perches-mx.perches.com ([206.117.179.246]:60045 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753206Ab2FFATe (ORCPT ); Tue, 5 Jun 2012 20:19:34 -0400 Message-ID: <1338941971.11962.20.camel@joe2Laptop> Subject: Re: [PATCH 0/8] Rework KERN_ From: Joe Perches To: Kay Sievers Cc: Andrew Morton , Linus Torvalds , linux-arm-kernel@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, alsa-devel@alsa-project.org Date: Tue, 05 Jun 2012 17:19:31 -0700 In-Reply-To: References: <20120605142826.d92316a0.akpm@linux-foundation.org> <1338934303.5780.8.camel@joe2Laptop> <20120605151754.a794ac7c.akpm@linux-foundation.org> <1338936572.5780.29.camel@joe2Laptop> <20120605162910.caccb0d4.akpm@linux-foundation.org> <1338939316.11962.3.camel@joe2Laptop> <1338939792.11962.4.camel@joe2Laptop> <1338940345.11962.9.camel@joe2Laptop> <20120605165808.cd255b93.akpm@linux-foundation.org> <1338941247.11962.16.camel@joe2Laptop> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.2- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 846 Lines: 26 On Wed, 2012-06-06 at 02:13 +0200, Kay Sievers wrote: > The question is what happens if you inject your new binary two-byte > prefix, like: > echo -e "\x01\x02Hello" > /dev/kmsg It's not a 2 byte binary. It's a leading ascii SOH and a standard ascii char '0' ... '7' or 'd'. #define KERN_EMERG KERN_SOH "0" /* system is unusable */ #define KERN_ALERT KERN_SOH "1" /* action must be taken immediately */ etc... > And if that changes the log-level to "2" instead of the default "4"? No it doesn't. It's not triggering that because devkmsg_writev does prefix parsing only on the old "" form. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/