Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753461Ab2FFJhz (ORCPT ); Wed, 6 Jun 2012 05:37:55 -0400 Received: from e6.ny.us.ibm.com ([32.97.182.146]:39541 "EHLO e6.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750713Ab2FFJhy (ORCPT ); Wed, 6 Jun 2012 05:37:54 -0400 Date: Wed, 6 Jun 2012 15:07:44 +0530 From: Ananth N Mavinakayanahalli To: Peter Zijlstra Cc: linuxppc-dev@lists.ozlabs.org, lkml , Paul Mackerras , benh@kernel.crashing.org, Srikar Dronamraju , Anton Blanchard , Ingo Molnar , oleg@redhat.com Subject: Re: [PATCH 1/2] uprobes: Pass probed vaddr to arch_uprobe_analyze_insn() Message-ID: <20120606093744.GB29580@in.ibm.com> Reply-To: ananth@in.ibm.com References: <20120606091950.GB6745@in.ibm.com> <1338974632.2749.87.camel@twins> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1338974632.2749.87.camel@twins> User-Agent: Mutt/1.5.17 (2007-11-01) X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12060609-1976-0000-0000-00000DDEA730 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 683 Lines: 16 On Wed, Jun 06, 2012 at 11:23:52AM +0200, Peter Zijlstra wrote: > On Wed, 2012-06-06 at 14:49 +0530, Ananth N Mavinakayanahalli wrote: > > +int arch_uprobe_analyze_insn(struct arch_uprobe *auprobe, struct mm_struct *mm, loff_t vaddr) > > Don't we traditionally use unsigned long to pass vaddrs? Right. But the vaddr we pass here is vma_info->vaddr which is loff_t. I guess I should've made that clear in the patch description. Ananth -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/