Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756554Ab2FFPJa (ORCPT ); Wed, 6 Jun 2012 11:09:30 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:51210 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755503Ab2FFPJ2 (ORCPT ); Wed, 6 Jun 2012 11:09:28 -0400 Date: Wed, 6 Jun 2012 11:09:27 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: "Rafael J. Wysocki" cc: Deepthi Dharwar , Kevin Hilman , Len Brown , Arnd Bergmann , Linux PM mailing list , "Tomas M." , LKML , Dave Hansen , "Srivatsa S. Bhat" , , , Ferenc Wagner , Arjan van de Ven , Jean Pihet Subject: Re: [linux-pm] Suspend/resume regressions on Lenovo S10-3 In-Reply-To: <201206061543.03537.rjw@sisk.pl> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 917 Lines: 30 On Wed, 6 Jun 2012, Rafael J. Wysocki wrote: > > --- a/drivers/acpi/processor_idle.c > > +++ b/drivers/acpi/processor_idle.c > > @@ -895,8 +895,9 @@ static int acpi_idle_enter_bm(struct cpuidle_device *dev, > > if (unlikely(!pr)) > > return -EINVAL; > > > > - > > if (acpi_idle_suspend) { > > + local_irq_disable(); > > + local_irq_enable(); > > cpu_relax(); > > return -EINVAL; > > } > > May I say this is ugly? Why can't we track the status of interrupts > properly here? It's not just ugly; it's illogical. What reason could there possibly be for disabling interrupts and then enabling them again without doing anything in between? Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/