Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757338Ab2FFSuD (ORCPT ); Wed, 6 Jun 2012 14:50:03 -0400 Received: from smtp-out002.kontent.com ([81.88.40.216]:57454 "EHLO smtp-out002.kontent.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752410Ab2FFSuC (ORCPT ); Wed, 6 Jun 2012 14:50:02 -0400 X-Greylist: delayed 533 seconds by postgrey-1.27 at vger.kernel.org; Wed, 06 Jun 2012 14:50:02 EDT From: Oliver Neukum To: Alan Stern Subject: Re: [PATCH] fix usb skeleton driver Date: Wed, 6 Jun 2012 20:37:53 +0200 User-Agent: KMail/1.13.5 (Linux/3.3.0-12-desktop+; KDE/4.4.4; x86_64; ; ) Cc: Ming Lei , stefani@seibold.net, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, alan@lxorguk.ukuu.org.uk, linux-usb@vger.kernel.org References: In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201206062037.53418.oliver@neukum.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 918 Lines: 23 Am Mittwoch, 6. Juni 2012, 17:06:59 schrieb Alan Stern: > On Wed, 6 Jun 2012, Ming Lei wrote: > > So many purposes, you need to split your patches for review easily, :-) > > Not just that... usb-skeleton is intended to be a good example, to > help people learn how to write USB drivers. It's already far too > complicated for this purpose, and adding more complication will just > make it worse. > > Instead of adding things to usb-skeleton, we should take things away. Not really. The features in the driver make sense. Probably we should have two versions. One simple and basic and the other showing advanced techniques. And a lot more comments. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/