From: Oliver Neukum <oliver@neukum.org>
To: stefani@seibold.net
Subject: Re: [PATCH 02/11] code cleanup
Date: Wed, 6 Jun 2012 20:57:59 +0200
User-Agent: KMail/1.13.5 (Linux/3.3.0-12-desktop+; KDE/4.4.4; x86_64; ; )
Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
        alan@lxorguk.ukuu.org.uk, linux-usb@vger.kernel.org
References: <1339000032-10313-1-git-send-email-stefani@seibold.net> <1339000032-10313-3-git-send-email-stefani@seibold.net>
In-Reply-To: <1339000032-10313-3-git-send-email-stefani@seibold.net>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201206062058.00020.oliver@neukum.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 756
Lines: 28

Am Mittwoch, 6. Juni 2012, 18:27:03 schrieb stefani@seibold.net:
> From: Stefani Seibold <stefani@seibold.net>
> 
> - consistent nameing
> - more compact style
> - remove unneeded code
> 

>  static int skel_flush(struct file *file, fl_owner_t id)
>  {
> -	struct usb_skel *dev;
> +	struct usb_skel *dev = file->private_data;
>  	int res;
>  
> -	dev = file->private_data;
> -	if (dev == NULL)
> -		return -ENODEV;
> -

flush() is intended to report errors. A check for disconnect is needed.

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/