Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758919Ab2FFVmA (ORCPT ); Wed, 6 Jun 2012 17:42:00 -0400 Received: from mail1-relais-roc.national.inria.fr ([192.134.164.82]:33774 "EHLO mail1-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758835Ab2FFVl4 (ORCPT ); Wed, 6 Jun 2012 17:41:56 -0400 X-IronPort-AV: E=Sophos;i="4.75,726,1330902000"; d="scan'208";a="161655290" From: Julia Lawall To: Wolfgang Grandegger Cc: kernel-janitors@vger.kernel.org, Marc Kleine-Budde , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, joe@perches.com, Julia Lawall Subject: [PATCH 7/7] drivers/net/can/cc770/cc770_platform.c: adjust suspicious bit operation Date: Wed, 6 Jun 2012 23:41:41 +0200 Message-Id: <1339018901-28439-8-git-send-email-Julia.Lawall@lip6.fr> X-Mailer: git-send-email 1.7.3.4 In-Reply-To: <1339018901-28439-1-git-send-email-Julia.Lawall@lip6.fr> References: <1339018901-28439-1-git-send-email-Julia.Lawall@lip6.fr> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1161 Lines: 31 From: Julia Lawall CPUIF_DSC is 0x40, so it would seem that & is wanted rather than |. This problem was found using Coccinelle (http://coccinelle.lip6.fr/). Signed-off-by: Julia Lawall --- drivers/net/can/cc770/cc770_platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/cc770/cc770_platform.c b/drivers/net/can/cc770/cc770_platform.c index 53115ee..688371c 100644 --- a/drivers/net/can/cc770/cc770_platform.c +++ b/drivers/net/can/cc770/cc770_platform.c @@ -154,7 +154,7 @@ static int __devinit cc770_get_platform_data(struct platform_device *pdev, struct cc770_platform_data *pdata = pdev->dev.platform_data; priv->can.clock.freq = pdata->osc_freq; - if (priv->cpu_interface | CPUIF_DSC) + if (priv->cpu_interface & CPUIF_DSC) priv->can.clock.freq /= 2; priv->clkout = pdata->cor; priv->bus_config = pdata->bcr; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/