Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759030Ab2FFVnt (ORCPT ); Wed, 6 Jun 2012 17:43:49 -0400 Received: from mail1-relais-roc.national.inria.fr ([192.134.164.82]:33774 "EHLO mail1-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758728Ab2FFVly (ORCPT ); Wed, 6 Jun 2012 17:41:54 -0400 X-IronPort-AV: E=Sophos;i="4.75,726,1330902000"; d="scan'208";a="161655287" From: Julia Lawall To: Alexander Viro Cc: kernel-janitors@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, joe@perches.com, Julia Lawall Subject: [PATCH 4/7] fs/direct-io.c: adjust suspicious bit operation Date: Wed, 6 Jun 2012 23:41:38 +0200 Message-Id: <1339018901-28439-5-git-send-email-Julia.Lawall@lip6.fr> X-Mailer: git-send-email 1.7.3.4 In-Reply-To: <1339018901-28439-1-git-send-email-Julia.Lawall@lip6.fr> References: <1339018901-28439-1-git-send-email-Julia.Lawall@lip6.fr> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1057 Lines: 32 From: Julia Lawall READ is 0, so the result of the bit-and operation is 0. Rewrite with == as done elsewhere in the same file. This problem was found using Coccinelle (http://coccinelle.lip6.fr/). Signed-off-by: Julia Lawall --- fs/direct-io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/direct-io.c b/fs/direct-io.c index 0c85fae..1faf4cb 100644 --- a/fs/direct-io.c +++ b/fs/direct-io.c @@ -1258,7 +1258,7 @@ do_blockdev_direct_IO(int rw, struct kiocb *iocb, struct inode *inode, */ BUG_ON(retval == -EIOCBQUEUED); if (dio->is_async && retval == 0 && dio->result && - ((rw & READ) || (dio->result == sdio.size))) + ((rw == READ) || (dio->result == sdio.size))) retval = -EIOCBQUEUED; if (retval != -EIOCBQUEUED) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/