Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758660Ab2FGAEm (ORCPT ); Wed, 6 Jun 2012 20:04:42 -0400 Received: from terminus.zytor.com ([198.137.202.10]:43913 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753693Ab2FGAEl (ORCPT ); Wed, 6 Jun 2012 20:04:41 -0400 Message-ID: <4FCFEFF0.5070108@zytor.com> Date: Wed, 06 Jun 2012 17:04:00 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Peter Zijlstra CC: Thomas Gleixner , Rusty Russell , Fenghua Yu , Ingo Molnar , Suresh B Siddha , Tony Luck , Asit K Mallick , Arjan Dan De Ven , linux-kernel , x86 , linux-pm , "Srivatsa S. Bhat" Subject: Re: [PATCH] kthread: Implement park/unpark facility References: <1338833876-29721-1-git-send-email-fenghua.yu@intel.com> <1338842001.28282.135.camel@twins> <87zk8iioam.fsf@rustcorp.com.au> <1338905159.28282.186.camel@twins> In-Reply-To: <1338905159.28282.186.camel@twins> X-Enigmail-Version: 1.4.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 843 Lines: 25 On 06/05/2012 07:05 AM, Peter Zijlstra wrote: > On Tue, 2012-06-05 at 15:41 +0200, Thomas Gleixner wrote: >> struct kthread { >> - int should_stop; >> + bool should_stop; >> + bool should_park; >> + bool is_parked; >> + bool is_percpu; > > bool doesn't have a well specified storage type. I typically try to > avoid using it in structures for this reason. Others might not care > though. > On all known Linux platforms, bool is implemented as a single byte having a value of either 0 or 1. However, it might make more sense to have a flags field here... -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/