Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759472Ab2FGCI5 (ORCPT ); Wed, 6 Jun 2012 22:08:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9949 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754756Ab2FGCI4 (ORCPT ); Wed, 6 Jun 2012 22:08:56 -0400 Date: Wed, 6 Jun 2012 22:08:47 -0400 From: Dave Jones To: Al Viro Cc: Linus Torvalds , Linux Kernel , Miklos Szeredi , Jan Kara , Peter Zijlstra Subject: Re: processes hung after sys_renameat, and 'missing' processes Message-ID: <20120607020846.GD17566@redhat.com> Mail-Followup-To: Dave Jones , Al Viro , Linus Torvalds , Linux Kernel , Miklos Szeredi , Jan Kara , Peter Zijlstra References: <20120606230040.GA18089@redhat.com> <20120606235403.GC30000@ZenIV.linux.org.uk> <20120607002914.GB22223@redhat.com> <20120607011915.GA17566@redhat.com> <20120607012900.GE30000@ZenIV.linux.org.uk> <20120607013149.GF30000@ZenIV.linux.org.uk> <20120607015410.GG30000@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120607015410.GG30000@ZenIV.linux.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 814 Lines: 22 On Thu, Jun 07, 2012 at 02:54:10AM +0100, Al Viro wrote: > > Do you even need the "dentry->d_parent != dentry" test? When do we > > even rename root dentries? > > Root of the filesystem - never; root of disconnected subtree - sure, > that's how they become connected to the tree. See d_materialize_unique(), > for example... > > BTW, I really need more coffee - those checks belong in __d_move(), > not d_move(); aforementioned d_materialize_unique() doesn't use d_move(), > it calls __d_move() directly. Sorry. np, I'll restart the build/test. Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/