MIME-Version: 1.0
In-Reply-To: <CAFR8uedHZ81JpY2jb0j9FLE3Uxibc=mSDFp496ChQLzkQqQdMw@mail.gmail.com>
References: <CAFR8ueeUH-O8+jeZu2Aeyu4ZDHv255a2qqnt0_Af79oY2JGzTw@mail.gmail.com>
	<CAOS58YOf0m5WUcn3b2f_PGr=P+DH1-0EHBy_fHw3xmccHW+zRA@mail.gmail.com>
	<CAFR8uedYpEX+9RiK11G-KvcEU7mYrt58OAFWs4mgoUpLQMowTQ@mail.gmail.com>
	<CAOS58YPAOYcHYkXu7hW-DeGRXkFqoF1cLarJFfh0eNfFaVHyBg@mail.gmail.com>
	<CAFR8uedHZ81JpY2jb0j9FLE3Uxibc=mSDFp496ChQLzkQqQdMw@mail.gmail.com>
Date: Thu, 7 Jun 2012 15:16:20 +0900
Message-ID: <CAOS58YNgatwyCApNg=sSNAzOSPR-QSqQwnYy562QcaUTcz8aOg@mail.gmail.com>
Subject: Re: [PATCH] blk-exec-assign-endio-before-queue-dead-check
From: Tejun Heo <tj@kernel.org>
To: Muthu Kumar <muthu.lkml@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>, James.Bottomley@hansenpartnership.com,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 784
Lines: 21

Hello, again.

On Thu, Jun 7, 2012 at 3:13 PM, Muthu Kumar <muthu.lkml@gmail.com> wrote:
> blk-exec.c: In blk_execute_rq_nowait(), if the queue is dead, call to
> done() routine is not made. That will result in blk_execute_rq() stuck
> in wait_for_completion(). Avoid this by initializing rq->end_io to
> done() routine before we check for dead queue.

Sorry to be nit-picky but Jens would appreciate proper subject and it
would also be nice to mention the locking change (or even separate
that into a separate patch).

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/