Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758176Ab2FGILb (ORCPT ); Thu, 7 Jun 2012 04:11:31 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:54012 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756782Ab2FGIL0 (ORCPT ); Thu, 7 Jun 2012 04:11:26 -0400 Date: Thu, 7 Jun 2012 09:11:08 +0100 From: Russell King - ARM Linux To: Artem Bityutskiy Cc: Roland Stigge , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, dwmw2@infradead.org, kevin.wells@nxp.com, srinivas.bakki@nxp.com, linux-arm-kernel@lists.infradead.org, hechtb@googlemail.com, lars@metafoo.de, b32955@freescale.com, leiwen@marvell.com Subject: Re: [PATCH v6] MTD: LPC32xx SLC NAND driver Message-ID: <20120607081108.GO8262@n2100.arm.linux.org.uk> References: <1338974414-5308-1-git-send-email-stigge@antcom.de> <1338989921.6875.50.camel@sauron.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1338989921.6875.50.camel@sauron.fi.intel.com> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 621 Lines: 16 On Wed, Jun 06, 2012 at 04:38:41PM +0300, Artem Bityutskiy wrote: > On Wed, 2012-06-06 at 11:20 +0200, Roland Stigge wrote: > > +#else > > +#define lpc32xx_nand_resume NULL > > +#define lpc32xx_nand_suspend NULL > > +#endif > > 0, not NULL. Err, what planet are you on there. These are _pointers_ to functions, so using a _pointer_ is more correct than using an _integer_. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/