Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760302Ab2FGJI2 (ORCPT ); Thu, 7 Jun 2012 05:08:28 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:36027 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755569Ab2FGJI1 (ORCPT ); Thu, 7 Jun 2012 05:08:27 -0400 Message-ID: <1339060101.5274.5.camel@phoenix> Subject: [PATCH RFC/RFT] regulator: palmas: Clear PALMAS_SMPS12_CTRL_MODE_ACTIVE_MASK bits in palmas_set_mode_smps From: Axel Lin To: linux-kernel@vger.kernel.org Cc: Graeme Gregory , Mark Brown , Liam Girdwood Date: Thu, 07 Jun 2012 17:08:21 +0800 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1466 Lines: 43 Current code actually clears more bits than PALMAS_SMPS12_CTRL_MODE_ACTIVE_MASK bits. Signed-off-by: Axel Lin --- Hi Graeme, I'm wandering if we need to clear the status bits. Current code actually clears bit[7:4] and bit[1:0] and set bit[7:6] to bit[3:2]. Looks like we only need to clear PALMAS_SMPS12_CTRL_MODE_ACTIVE_MASK bit[1:0] bits here. and this change makes the intent more clear. I don't have this hardware, I'd appreciate if you can test this patch if you think this change ok. Regards, Axel drivers/regulator/palmas-regulator.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c index 92f475c..ae0951a 100644 --- a/drivers/regulator/palmas-regulator.c +++ b/drivers/regulator/palmas-regulator.c @@ -257,8 +257,7 @@ static int palmas_set_mode_smps(struct regulator_dev *dev, unsigned int mode) unsigned int reg; palmas_smps_read(pmic->palmas, palmas_regs_info[id].ctrl_addr, ®); - reg &= ~PALMAS_SMPS12_CTRL_STATUS_MASK; - reg >>= PALMAS_SMPS12_CTRL_STATUS_SHIFT; + reg &= ~PALMAS_SMPS12_CTRL_MODE_ACTIVE_MASK; switch (mode) { case REGULATOR_MODE_NORMAL: -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/