Date: Thu, 07 Jun 2012 11:47:21 +0200
Message-ID: <s5h4nqn78t2.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Steven Newbury <steve@snewbury.org.uk>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: hda - HDMI Audio init all connectors
In-Reply-To: <4FD06DA8.8090306@snewbury.org.uk>
References: <1339048379.2910.9.camel@Nokia-N900>
	<s5hd35b7bk4.wl%tiwai@suse.de>
	<4FD06DA8.8090306@snewbury.org.uk>
User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2027
Lines: 54

At Thu, 07 Jun 2012 10:00:24 +0100,
Steven Newbury wrote:
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 07/06/12 09:47, Takashi Iwai wrote:
> > At the next time you submit a patch, please add Cc to maintainer
> > and subsystem ML.  Otherwise it'd be easily overlooked.
> > 
> I meant to, somehow I managed to send it off before adding the CC,
> probably too early in the morning!
> 
> > At Thu, 07 Jun 2012 06:52:59 +0100, Steven Newbury wrote:
> >> 
> >> When VGA_SWITCHEROO support is enabled hda_intel initialises the
> >> HDMI audio device on the current VGA device.  When it's not
> >> enabled it only initialises the HDMI device on the default VGA
> >> adaptor, this means secondary cards get no audio support which is
> >> very unhelpful for multi-seat!
> >> 
> >> With this patch, when SUPPORT_VGA_SWITCHEROO is disabled
> >> hda_intel initialises all HDMI audio devices, not just the
> >> default VGA.
> >> 
> >> Signed-off-by: Steven Newbury <steve@snewbury.org.uk>
> > 
> > OK, it must be fixed indeed.  The bug was introduced due to the
> > change in VGA-switcheroo side -- originally check_hdmi_disabled()
> > really checked the VGA-switcheroo state, so it returned the correct
> > value in the earlier version.
> > 
> > In anyway, your patch looks almost OK, but it'd be better to move 
> > ifdef and simplify like below.  Could you check whether it works
> > for you?
> > 
> Looks better, saves the pointless function call. I'll give it spin on
> my next boot.

Thanks!

Meanwhile I found that the current version is also buggy for some
setups with VGA-switcheroo.  The current version won't work, for
example, when VGA-switcheroo is built-in for systems without
switcheroo.  I'll need to cook up the fix for 3.5-rc2 in addition to
your fix.


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/