Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932339Ab2FGLQK (ORCPT ); Thu, 7 Jun 2012 07:16:10 -0400 Received: from casper.infradead.org ([85.118.1.10]:53195 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755851Ab2FGLQI convert rfc822-to-8bit (ORCPT ); Thu, 7 Jun 2012 07:16:08 -0400 Message-ID: <1339067757.23343.21.camel@twins> Subject: Re: [PATCH] perf/x86: check ucode before disabling PEBS on SandyBridge From: Peter Zijlstra To: Stephane Eranian Cc: linux-kernel@vger.kernel.org, andi@firstfloor.org, mingo@elte.hu, ming.m.lin@intel.com Date: Thu, 07 Jun 2012 13:15:57 +0200 In-Reply-To: References: <20120607071531.GA4849@quad> <1339064319.23343.13.camel@twins> <1339065932.23343.18.camel@twins> Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Mailer: Evolution 3.2.2- Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 730 Lines: 17 On Thu, 2012-06-07 at 12:48 +0200, Stephane Eranian wrote: > >> The warning could also be done on boot. But the check has to be done > >> when the event is created. > > > > Is this because of the ucode loader not having done its thing yet etc..? Ah, its because you can update ucode at runtime of course. A quick look at the ucode loader doesn't show it having a notifier either, so then yeah we need to check on every event creation :/ Or we could put a hook in the ucode loader. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/