Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752600Ab2FGMRD (ORCPT ); Thu, 7 Jun 2012 08:17:03 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:43402 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751231Ab2FGMRA (ORCPT ); Thu, 7 Jun 2012 08:17:00 -0400 Message-ID: <4FD09B92.1020600@mvista.com> Date: Thu, 07 Jun 2012 16:16:18 +0400 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Namjae Jeon CC: James.Bottomley@HansenPartnership.com, gregkh@linuxfoundation.org, mdharm-usb@one-eyed-alien.net, linux-usb@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Namjae Jeon , Pankaj Kumar , Amit Sahrawat Subject: Re: [PATCH 1/3] scsi: set to WCE if usb cache quirk is present. References: <1338985224-9684-1-git-send-email-linkinjeon@gmail.com> In-Reply-To: <1338985224-9684-1-git-send-email-linkinjeon@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1571 Lines: 48 Hello. On 06-06-2012 16:20, Namjae Jeon wrote: > Make use of USB quirk method to identify such HDD while reading the cache status in sd_probe(). If cache quirk is present for the HDD, lets assume that cache is enabled and make WCE bit equal to 1. > Signed-off-by: Namjae Jeon > Signed-off-by: Pankaj Kumar > Signed-off-by: Amit Sahrawat > --- > drivers/scsi/sd.c | 9 +++++++-- > include/scsi/scsi_device.h | 1 + > 2 files changed, 8 insertions(+), 2 deletions(-) > diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c > index 6f0a4c6..33faf6d 100644 > --- a/drivers/scsi/sd.c > +++ b/drivers/scsi/sd.c > @@ -2259,8 +2259,13 @@ bad_sense: > sd_printk(KERN_ERR, sdkp, "Asking for cache data failed\n"); > > defaults: > - sd_printk(KERN_ERR, sdkp, "Assuming drive cache: write through\n"); > - sdkp->WCE = 0; > + if (sdp->wce_quirk) { > + sdkp->WCE = 1; > + sd_printk(KERN_NOTICE, sdkp, "Assuming drive cache write back\n"); You forgot colon after "cache". > + } else { > + sd_printk(KERN_ERR, sdkp, "Assuming drive cache: write through\n"); > + sdkp->WCE = 0; It makes sense to do assignments and printk() in the same order in both branches. > + } > sdkp->RCD = 0; > sdkp->DPOFUA = 0; > } WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/