Message-ID: <1339073661.7559.1.camel@gandalf.stny.rr.com>
Subject: Re: [PATCH] Use test_and_clear_bit() instead atomic_dec_and_test()
 for stop_machine
From: Steven Rostedt <rostedt@goodmis.org>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: Ingo Molnar <mingo@elte.hu>, Masami Hiramatsu <mhiramat@redhat.com>,
        linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>
Date: Thu, 07 Jun 2012 08:54:21 -0400
In-Reply-To: <87mx4zr0l9.fsf@devron.myhome.or.jp>
References: <87likkt7u6.fsf@devron.myhome.or.jp>
	 <87ehqct7a3.fsf@devron.myhome.or.jp>
	 <20120522214633.GB30024@home.goodmis.org>
	 <87aa0zty4r.fsf@devron.myhome.or.jp> <87mx4zr0l9.fsf@devron.myhome.or.jp>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 774
Lines: 22

On Wed, 2012-05-23 at 13:19 +0900, OGAWA Hirofumi wrote:
> OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> writes:
> 
> >> The down side to this is that it adds 4 more bytes on a 64bit
> >> machine. (sizeof(unsigned log) == 8 and sizeof(atomic_t) == 4)
> 
> Another patch without additional 4bytes. This simply change
> atomic_dec_and_test() to atomic_xchg().
> 

If nobody picked this up, you might want to resend it with my acked-by.
(The second patch, not the first). As patches added to replies are
usually ignored.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/