Date: Thu, 7 Jun 2012 12:14:34 -0500
From: Nathan Zimmer <nzimmer@sgi.com>
To: Don Zickus <dzickus@redhat.com>
Cc: Nathan Zimmer <nzimmer@sgi.com>, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] watchdog: reduce "NMI watchdog enabled, takes one
	hw-pmu counter." messages
Message-ID: <20120607171433.GA21139@gulag1.americas.sgi.com>
References: <20120606180946.GA16566@gulag1.americas.sgi.com> <20120606211523.GF32472@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120606211523.GF32472@redhat.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1167
Lines: 33

On Wed, Jun 06, 2012 at 05:15:23PM -0400, Don Zickus wrote:
> On Wed, Jun 06, 2012 at 01:09:46PM -0500, Nathan Zimmer wrote:
> >  watchdog: reduces some noise on a large system
> >  The printk buffer can be flooded with with redundant
> >  "NMI watchdog enabled, takes one hw-pmu counter." messages.
> >  It doesn't add any value beyond the first.
> > 
> >  Note the message needs logged a second time if the watchdog was disabled then
> >  reenabled.
> 
> Hi Nathan,
> 
> Thanks for the patch.  I added something similar to RHEL-6 a while ago
> that solved the same problem in a more robust way (I think).  IOW, I dealt
> with the watchdog failures too (for virt and bios issues).
> 
> It doesn't cover the nmi_disable case like your patch does, but is easy to
> add.
> 
> I attached it below.  Let me know if this meets your needs or not?
> 
> Cheers,
> Don

Yes it does seem to meet my needs quite well.

Thanks,
Nate 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/