Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761259Ab2FGSgu (ORCPT ); Thu, 7 Jun 2012 14:36:50 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]:30915 "EHLO acsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751626Ab2FGSgt (ORCPT ); Thu, 7 Jun 2012 14:36:49 -0400 Date: Thu, 7 Jun 2012 14:28:56 -0400 From: Konrad Rzeszutek Wilk To: Sasha Levin Cc: konrad@darnok.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, dan.magenheimer@oracle.com Subject: Re: [PATCH 05/11] mm: frontswap: split frontswap_shrink further to eliminate locking games Message-ID: <20120607182856.GZ9472@phenom.dumpdata.com> References: <1338980115-2394-1-git-send-email-levinsasha928@gmail.com> <1338980115-2394-5-git-send-email-levinsasha928@gmail.com> <1338982637.3292.63.camel@lappy> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1338982637.3292.63.camel@lappy> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 825 Lines: 20 On Wed, Jun 06, 2012 at 01:37:17PM +0200, Sasha Levin wrote: > On Wed, 2012-06-06 at 07:30 -0400, Konrad Rzeszutek Wilk wrote: > > > > On Jun 6, 2012 6:55 AM, "Sasha Levin" wrote: > > > > > > Split frontswap_shrink to eliminate the locking issues in the > > original code. > > > > Can you describe the locking issue please? > > I may have worded that wrong, it's less of an "issue" and more of a > complicated code to deal with locking, specifically the extra local > variable to keep track whether we are locking or not. So "simplying the locking"? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/