Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933459Ab2FGXHa (ORCPT ); Thu, 7 Jun 2012 19:07:30 -0400 Received: from mail-ey0-f174.google.com ([209.85.215.174]:50200 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755573Ab2FGXH3 (ORCPT ); Thu, 7 Jun 2012 19:07:29 -0400 MIME-Version: 1.0 In-Reply-To: <4FD09B92.1020600@mvista.com> References: <1338985224-9684-1-git-send-email-linkinjeon@gmail.com> <4FD09B92.1020600@mvista.com> Date: Fri, 8 Jun 2012 08:07:27 +0900 Message-ID: Subject: Re: [PATCH 1/3] scsi: set to WCE if usb cache quirk is present. From: Namjae Jeon To: Sergei Shtylyov Cc: James.Bottomley@hansenpartnership.com, gregkh@linuxfoundation.org, mdharm-usb@one-eyed-alien.net, linux-usb@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Namjae Jeon , Pankaj Kumar , Amit Sahrawat Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1744 Lines: 58 Hi. Sergei. Good point. I will update. Thanks for your review. 2012/6/7, Sergei Shtylyov : > Hello. > > On 06-06-2012 16:20, Namjae Jeon wrote: > >> Make use of USB quirk method to identify such HDD while reading the cache >> status in sd_probe(). If cache quirk is present for the HDD, lets assume >> that cache is enabled and make WCE bit equal to 1. > >> Signed-off-by: Namjae Jeon >> Signed-off-by: Pankaj Kumar >> Signed-off-by: Amit Sahrawat >> --- >> drivers/scsi/sd.c | 9 +++++++-- >> include/scsi/scsi_device.h | 1 + >> 2 files changed, 8 insertions(+), 2 deletions(-) > >> diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c >> index 6f0a4c6..33faf6d 100644 >> --- a/drivers/scsi/sd.c >> +++ b/drivers/scsi/sd.c >> @@ -2259,8 +2259,13 @@ bad_sense: >> sd_printk(KERN_ERR, sdkp, "Asking for cache data failed\n"); >> >> defaults: >> - sd_printk(KERN_ERR, sdkp, "Assuming drive cache: write through\n"); >> - sdkp->WCE = 0; >> + if (sdp->wce_quirk) { >> + sdkp->WCE = 1; >> + sd_printk(KERN_NOTICE, sdkp, "Assuming drive cache write back\n"); > > You forgot colon after "cache". > >> + } else { >> + sd_printk(KERN_ERR, sdkp, "Assuming drive cache: write through\n"); >> + sdkp->WCE = 0; > > It makes sense to do assignments and printk() in the same order in both > > branches. > >> + } >> sdkp->RCD = 0; >> sdkp->DPOFUA = 0; >> } > > WBR, Sergei > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/