Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759328Ab2FHA7l (ORCPT ); Thu, 7 Jun 2012 20:59:41 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:56192 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755725Ab2FHA7k (ORCPT ); Thu, 7 Jun 2012 20:59:40 -0400 Date: Fri, 8 Jun 2012 01:59:35 +0100 From: Al Viro To: Linus Torvalds Cc: "Eric W. Biederman" , Dave Jones , Linux Kernel , Miklos Szeredi , Jan Kara , Peter Zijlstra , linux-fsdevel@vger.kernel.org, "J. Bruce Fields" , Sage Weil Subject: Re: processes hung after sys_renameat, and 'missing' processes Message-ID: <20120608005935.GL30000@ZenIV.linux.org.uk> References: <20120606235403.GC30000@ZenIV.linux.org.uk> <20120607002914.GB22223@redhat.com> <20120607011915.GA17566@redhat.com> <20120607012900.GE30000@ZenIV.linux.org.uk> <20120607193607.GI30000@ZenIV.linux.org.uk> <873966n2c2.fsf@xmission.com> <20120608003604.GK30000@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120608003604.GK30000@ZenIV.linux.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 903 Lines: 17 On Fri, Jun 08, 2012 at 01:36:04AM +0100, Al Viro wrote: > Eric, how about this - if nothing else, that makes code in there simpler > and less dependent on details of VFS guts: Argh. No, it's not enough. Why are you using ->d_iput()? You are not doing anything unusual with inode; the natural place for that is in ->d_release() and then it will get simpler rules wrt setting ->d_fsdata. As it is, you need to do that exactly after the point where you know that it dentry won't be dropped without going through d_add(). OK, I've split that in two commits and put into vfs.git#sysfs; take a look and comment, please. Should get to git.kernel.in a few... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/