Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761797Ab2FHFMf (ORCPT ); Fri, 8 Jun 2012 01:12:35 -0400 Received: from mail4-relais-sop.national.inria.fr ([192.134.164.105]:55931 "EHLO mail4-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761774Ab2FHFMc (ORCPT ); Fri, 8 Jun 2012 01:12:32 -0400 X-IronPort-AV: E=Sophos;i="4.75,734,1330902000"; d="scan'208";a="146977945" Date: Fri, 8 Jun 2012 07:12:18 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: David Miller cc: Julia.Lawall@lip6.fr, kernel-janitors@vger.kernel.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, joe@perches.com, julia@diku.dk Subject: Re: [PATCH 1/7] drivers/ide/ide-cs.c: adjust suspicious bit operation In-Reply-To: <20120607.144616.2224976714259476349.davem@davemloft.net> Message-ID: References: <1339018901-28439-1-git-send-email-Julia.Lawall@lip6.fr> <1339018901-28439-2-git-send-email-Julia.Lawall@lip6.fr> <20120607.144616.2224976714259476349.davem@davemloft.net> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 750 Lines: 21 On Thu, 7 Jun 2012, David Miller wrote: > From: Julia Lawall > Date: Wed, 6 Jun 2012 23:41:35 +0200 > >> - if (!(pdev->resource[0]->flags & IO_DATA_PATH_WIDTH_8)) { >> + if ((p1dev->resource[0]->flags & IO_DATA_PATH_WIDTH) > > I'm really surprised someone as thorough as yourself did not > compile test this. Sorry, I changed the patch at the last minute, and it was indeed not a good idea not to have compiled again. I will send another version, in case it is useful. julia -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/