Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932731Ab2FHMcU (ORCPT ); Fri, 8 Jun 2012 08:32:20 -0400 Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:27967 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756314Ab2FHMcS (ORCPT ); Fri, 8 Jun 2012 08:32:18 -0400 X-Mail-Handler: MailHop Outbound by DynDNS X-Originating-IP: 98.234.237.12 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/mailhop/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX190qBbJoEJmH+h/K7gDZB3J Date: Fri, 8 Jun 2012 05:32:13 -0700 From: Tony Lindgren To: Linus Walleij Cc: Thomas Abraham , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, grant.likely@secretlab.ca, kgene.kim@samsung.com, kyungmin.park@samsung.com, patches@linaro.org, Stephen Warren Subject: Re: [PATCH 1/3] pinctrl: add samsung pinctrl and gpiolib driver Message-ID: <20120608123213.GP12766@atomide.com> References: <1337816857-14694-1-git-send-email-thomas.abraham@linaro.org> <1337816857-14694-2-git-send-email-thomas.abraham@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1260 Lines: 33 * Linus Walleij [120531 18:40]: > On Thu, May 24, 2012 at 7:47 AM, Thomas Abraham > wrote: > > > diff --git a/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt > > It would be nice if some DT person could review the bindings, but if > nothing happens > I will accept them as-is. Looks OK to me, that's a bit slower way of parsing pins compared to just register value pairs but allows naming them. And it was agreed that it's up to the driver to define it's binding. > This driver is special since it seems to keep all pin, group and > function information > in the device tree, but not like Tony is doing it in pinctrl-simple, > if I understand > correctly? Looks like it's using static arrays which I was too using earlier. That too should be OK for now, then at some point we can probably have something generic to manage the pins for at least some drivers. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/