Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932369Ab2FHNtL (ORCPT ); Fri, 8 Jun 2012 09:49:11 -0400 Received: from 8bytes.org ([85.214.48.195]:57392 "EHLO h2027444.stratoserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756555Ab2FHNtJ (ORCPT ); Fri, 8 Jun 2012 09:49:09 -0400 Date: Fri, 8 Jun 2012 15:49:05 +0200 From: Joerg Roedel To: Bryan Schumaker Cc: Trond Myklebust , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: NFS regression in v3.5-rc1: mount.nfs yells about incorrect mount option Message-ID: <20120608134905.GX12795@8bytes.org> References: <20120607150456.GO12795@8bytes.org> <4FD0C4C2.8020605@netapp.com> <20120607155006.GR12795@8bytes.org> <4FD0CEB0.9040804@netapp.com> <20120608130352.GU12795@8bytes.org> <4FD1FC02.2000608@netapp.com> <20120608133317.GW12795@8bytes.org> <4FD1FFFD.3020301@netapp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4FD1FFFD.3020301@netapp.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-DSPAM-Result: Whitelisted X-DSPAM-Processed: Fri Jun 8 15:49:06 2012 X-DSPAM-Confidence: 0.9982 X-DSPAM-Probability: 0.0000 X-DSPAM-Signature: 4fd202d228388073069913 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1392 Lines: 38 On Fri, Jun 08, 2012 at 09:37:01AM -0400, Bryan Schumaker wrote: > On 06/08/2012 09:33 AM, Joerg Roedel wrote: > > Your other patch only touched the nfs4 path, but in my setup nfs3 was in > > use. Therefore the patch didn't help. I just figured out that > > nfs_fs_mount is shared between nfs23 and nfs4, so the first patch > > probably breaks nfs4. I send another one which takes this into account. > > Would something like this work? (I haven't tried it yet). Setting it > in nfs_alloc_parsed_mount_data() might work too... > > diff --git a/fs/nfs/super.c b/fs/nfs/super.c > index bdd6731..906f09c 100644 > --- a/fs/nfs/super.c > +++ b/fs/nfs/super.c > @@ -1867,6 +1867,7 @@ static int nfs23_validate_mount_data(void *options, > if (data == NULL) > goto out_no_data; > > + args->version = NFS_DEFAULT_VERSION; > switch (data->version) { > case 1: > data->namlen = 0; > -- Yes, this works too (tested). Doing it in nfs_alloc_parsed_mount_data() need to take into account that the function is also called for nfs4. This is basically what my second revert-patch does. Joerg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/