Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934315Ab2FHOXg (ORCPT ); Fri, 8 Jun 2012 10:23:36 -0400 Received: from merlin.infradead.org ([205.233.59.134]:51456 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932806Ab2FHOXf (ORCPT ); Fri, 8 Jun 2012 10:23:35 -0400 Subject: Re: [PATCH] perf/x86: check ucode before disabling PEBS on SandyBridge From: Peter Zijlstra To: Stephane Eranian Cc: Ingo Molnar , linux-kernel@vger.kernel.org, andi@firstfloor.org, mingo@elte.hu, ming.m.lin@intel.com, Andreas Herrmann , Borislav Petkov , Dimitri Sivanich , Dmitry Adamushko In-Reply-To: References: <20120607071531.GA4849@quad> <1339064319.23343.13.camel@twins> <1339065932.23343.18.camel@twins> <1339067757.23343.21.camel@twins> <20120608093513.GA22520@gmail.com> <1339149613.23343.52.camel@twins> <1339161972.2507.13.camel@laptop> Content-Type: text/plain; charset="UTF-8" Date: Fri, 08 Jun 2012 16:23:10 +0200 Message-ID: <1339165390.2507.28.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 652 Lines: 15 On Fri, 2012-06-08 at 16:07 +0200, Stephane Eranian wrote: > > +extern struct blocking_notifier_head microcode_notifier; > > + > That is a problem because microcode can be compiled as a module. > When I tried compiling your patch I got undefined for this notifier because > I have microcode update as a module... Ah, no, setup.c needs an EXPORT_SYMBOL_GPL(microcode_notifier);. Then it all builds again. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/