Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934341Ab2FHO0J (ORCPT ); Fri, 8 Jun 2012 10:26:09 -0400 Received: from mail-lpp01m010-f46.google.com ([209.85.215.46]:61665 "EHLO mail-lpp01m010-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932242Ab2FHO0G (ORCPT ); Fri, 8 Jun 2012 10:26:06 -0400 MIME-Version: 1.0 In-Reply-To: <1339165501.2507.30.camel@laptop> References: <20120607071531.GA4849@quad> <1339064319.23343.13.camel@twins> <1339065932.23343.18.camel@twins> <1339067757.23343.21.camel@twins> <20120608093513.GA22520@gmail.com> <1339149613.23343.52.camel@twins> <1339161972.2507.13.camel@laptop> <1339165501.2507.30.camel@laptop> Date: Fri, 8 Jun 2012 16:26:04 +0200 Message-ID: Subject: Re: [PATCH] perf/x86: check ucode before disabling PEBS on SandyBridge From: Stephane Eranian To: Peter Zijlstra Cc: Ingo Molnar , linux-kernel@vger.kernel.org, andi@firstfloor.org, mingo@elte.hu, ming.m.lin@intel.com, Andreas Herrmann , Borislav Petkov , Dimitri Sivanich , Dmitry Adamushko Content-Type: text/plain; charset=UTF-8 X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 767 Lines: 20 On Fri, Jun 8, 2012 at 4:25 PM, Peter Zijlstra wrote: > On Fri, 2012-06-08 at 16:07 +0200, Stephane Eranian wrote: >> > +static const u32 snb_ucode_rev = 0x28; >> > + >> >> That needs to be a per CPU model value. It >> is not the same for SNB vs. SNB-EP. On EP >> it may even depends on stepping. > > Yeah, you said, easiest is removing the const and putting some > assignments to the thing somewhere in our model switch. > > Do you know what values for what chip we should use? > Checking on that. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/