Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762298Ab2FHRod (ORCPT ); Fri, 8 Jun 2012 13:44:33 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:63141 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752127Ab2FHRob convert rfc822-to-8bit (ORCPT ); Fri, 8 Jun 2012 13:44:31 -0400 MIME-Version: 1.0 In-Reply-To: <20120608162234.GB17251@fieldses.org> References: <20120606194233.GA1537@redhat.com> <20120606230040.GA18089@redhat.com> <20120606235403.GC30000@ZenIV.linux.org.uk> <20120607002914.GB22223@redhat.com> <20120607011915.GA17566@redhat.com> <20120607012900.GE30000@ZenIV.linux.org.uk> <20120607193607.GI30000@ZenIV.linux.org.uk> <20120608162234.GB17251@fieldses.org> From: Linus Torvalds Date: Fri, 8 Jun 2012 10:44:09 -0700 X-Google-Sender-Auth: LMQw7ZoPKoHdyagD0GFt4shlZHY Message-ID: Subject: Re: processes hung after sys_renameat, and 'missing' processes To: "J. Bruce Fields" Cc: Al Viro , Dave Jones , Linux Kernel , Miklos Szeredi , Jan Kara , Peter Zijlstra , linux-fsdevel@vger.kernel.org, "J. Bruce Fields" , "Eric W. Biederman" , Sage Weil Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1241 Lines: 26 On Fri, Jun 8, 2012 at 9:22 AM, J. Bruce Fields wrote: > On Thu, Jun 07, 2012 at 08:36:07PM +0100, Al Viro wrote: > >> I really believe that this pair of commits needs to be reverted. ?The >> earlier code used to guarantee that alias would be detached. > > In the case that prompted that first commit, the directory in question > had an alias that was detached (which I'm taking to mean IS_ROOT(dentry) > was true?), but not flagged DISCONNECTED. ?The particular case was only > reproduceable on an older kernel, and I couldn't find a similar > reproducer on recent upstream, but I also couldn't convince myself it > was impossible. > > So, maybe the correct thing is to revert that change. ?Or maybe it > should be picking an IS_ROOT dentry instead of a DISCONNECTED one? I've reverted the changes for now, it looks like the discussion about them is still on-going, and I think I'll feel happier if we just go back to the old status quo for the nonce. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/