Message-ID: <1339182786.2297.10.camel@localhost.localdomain>
Subject: Re: [PATCH 0/2] Move the tpm_get_random api and add an hwrng driver
 for it
From: David Safford <safford@linux.vnet.ibm.com>
To: Kent Yoder <key@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, tpmdd-devel@lists.sourceforge.net,
        m.selhorst@sirrix.com, David Safford <safford@us.ibm.com>
Date: Fri, 08 Jun 2012 15:13:06 -0400
In-Reply-To: <1339094567.21398.2.camel@key-ThinkPad-W510>
References: <1339094567.21398.2.camel@key-ThinkPad-W510>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1402
Lines: 33

On Thu, 2012-06-07 at 13:42 -0500, Kent Yoder wrote:
> These patches move the tpm_get_random API out of the trusted keys code
> and into the tpm device driver itself.  Then a hwrng driver is added that
> makes use of the API to provide a H/W RNG source.

Very nice! checkpatch complained a bit on patch 1, but otherwise,
Acked-by: David Safford <safford@linux.vnet.ibm.com>

>   These are based off the latest upstream kernel.
> 
> Thanks,
> Kent
> 
> Kent Yoder (2):
>   tpm: Move tpm_get_random api into the TPM device driver
>   hw_random: add support for the TPM chip as a hardware RNG source
> 
>  drivers/char/hw_random/Kconfig   |   13 +++++++++
>  drivers/char/hw_random/Makefile  |    1 +
>  drivers/char/hw_random/tpm-rng.c |   55 ++++++++++++++++++++++++++++++++++++++
>  drivers/char/tpm/tpm.c           |   53 ++++++++++++++++++++++++++++++++----
>  drivers/char/tpm/tpm.h           |   23 ++++++++++++++++
>  include/linux/tpm.h              |    4 +++
>  security/keys/trusted.c          |   47 +++++++-------------------------
>  7 files changed, 153 insertions(+), 43 deletions(-)
>  create mode 100644 drivers/char/hw_random/tpm-rng.c
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/