Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753487Ab2FIX52 (ORCPT ); Sat, 9 Jun 2012 19:57:28 -0400 Received: from mail-vc0-f174.google.com ([209.85.220.174]:42742 "EHLO mail-vc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750843Ab2FIX51 (ORCPT ); Sat, 9 Jun 2012 19:57:27 -0400 MIME-Version: 1.0 In-Reply-To: <4FD345DC.6020405@acm.org> References: <4FD345DC.6020405@acm.org> Date: Sat, 9 Jun 2012 16:57:26 -0700 Message-ID: Subject: Re: [PATCH UPDATED] block: In blk_execute_rq_nowait, init rq->end_io before checking for dead queue. From: Muthu Kumar To: Bart Van Assche Cc: Jens Axboe , Tejun Heo , Jej B , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Content-Type: multipart/mixed; boundary=20cf3079ba3af5576304c212e069 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2544 Lines: 63 --20cf3079ba3af5576304c212e069 Content-Type: text/plain; charset=ISO-8859-1 On Sat, Jun 9, 2012 at 5:47 AM, Bart Van Assche wrote: > On 06/09/12 00:10, Muthu Kumar wrote: > >> Since the queue->lock case is taken care of in the following patch: >> >> (http://www.spinics.net/lists/linux-scsi/msg59845.html [PATCH 1/4] >> block: Fix race on request_queue.end_io invocations) >> >> Updated the patch with just the end_io assignment before dead queue check. >> >> > > > This patch does not apply since it's line-wrapped and a part is missing > in the second hunk. However, if I had overlooked your original patch > then I want to apologize. > Please use the attached file since gmail messes with the line wraps. > If you can resend your original patch including the locking changes then > I'll test it further. > Locking change is the one you posted already (the link above). Anyway, I have the attached patch *including* the locking change. Original mail has attachment without locking change. Please use whatever you need. Thanks for testing. Regards, Muthu > Bart. --20cf3079ba3af5576304c212e069 Content-Type: text/x-diff; charset=US-ASCII; name="blk-exec-patch-to-bart.patch" Content-Disposition: attachment; filename="blk-exec-patch-to-bart.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_h39cda0y0 ZGlmZiAtLWdpdCBhL2Jsb2NrL2Jsay1leGVjLmMgYi9ibG9jay9ibGstZXhlYy5jCmluZGV4IGZi MmNiZDUuLjI4NGJmNTYgMTAwNjQ0Ci0tLSBhL2Jsb2NrL2Jsay1leGVjLmMKKysrIGIvYmxvY2sv YmxrLWV4ZWMuYwpAQCAtNTMsMTYgKzUzLDE3IEBAIHZvaWQgYmxrX2V4ZWN1dGVfcnFfbm93YWl0 KHN0cnVjdCByZXF1ZXN0X3F1ZXVlICpxLCBzdHJ1Y3QgZ2VuZGlzayAqYmRfZGlzaywKIAlXQVJO X09OKGlycXNfZGlzYWJsZWQoKSk7CiAJc3Bpbl9sb2NrX2lycShxLT5xdWV1ZV9sb2NrKTsKIAor CXJxLT5ycV9kaXNrID0gYmRfZGlzazsKKwlycS0+ZW5kX2lvID0gZG9uZTsKKwogCWlmICh1bmxp a2VseShibGtfcXVldWVfZGVhZChxKSkpIHsKLQkJc3Bpbl91bmxvY2tfaXJxKHEtPnF1ZXVlX2xv Y2spOwogCQlycS0+ZXJyb3JzID0gLUVOWElPOwogCQlpZiAocnEtPmVuZF9pbykKIAkJCXJxLT5l bmRfaW8ocnEsIHJxLT5lcnJvcnMpOworCQlzcGluX3VubG9ja19pcnEocS0+cXVldWVfbG9jayk7 CiAJCXJldHVybjsKIAl9CiAKLQlycS0+cnFfZGlzayA9IGJkX2Rpc2s7Ci0JcnEtPmVuZF9pbyA9 IGRvbmU7CiAJX19lbHZfYWRkX3JlcXVlc3QocSwgcnEsIHdoZXJlKTsKIAlfX2Jsa19ydW5fcXVl dWUocSk7CiAJLyogdGhlIHF1ZXVlIGlzIHN0b3BwZWQgc28gaXQgd29uJ3QgYmUgcnVuICovCg== --20cf3079ba3af5576304c212e069-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/