Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752730Ab2FJHsd (ORCPT ); Sun, 10 Jun 2012 03:48:33 -0400 Received: from mga11.intel.com ([192.55.52.93]:56275 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751112Ab2FJHsA (ORCPT ); Sun, 10 Jun 2012 03:48:00 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.71,315,1320652800"; d="scan'208";a="163724757" Date: Sun, 10 Jun 2012 15:47:52 +0800 From: Fengguang Wu To: Wanpeng Li Cc: LKML , Jan Kara , Andrew Morton , Peter Zijlstra , Johannes Weiner , linux-mm@kvack.org, Gavin Shan , Wanpeng Li Subject: Re: [PATCH] page-writeback.c: fix update bandwidth time judgment error Message-ID: <20120610074752.GA11506@localhost> References: <1339302005-366-1-git-send-email-liwp.linux@gmail.com> <20120610043641.GA10355@localhost> <20120610045300.GA29336@kernel> <20120610072414.GA11283@localhost> <20120610074115.GA2400@kernel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120610074115.GA2400@kernel> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1056 Lines: 34 > static void global_update_bandwidth(unsigned long thresh, > unsigned long dirty, > unsigned long now) > { > static DEFINE_SPINLOCK(dirty_lock); > static unsigned long update_time; > > /* > * check locklessly first to optimize away locking for the most time > */ > if (time_before(now, update_time + BANDWIDTH_INTERVAL)) > return; > > spin_lock(&dirty_lock); > if (time_after_eq(now, update_time + BANDWIDTH_INTERVAL)) { > update_dirty_limit(thresh, dirty); > update_time = now; > } > spin_unlock(&dirty_lock); > } > > So time_after_eq in global_update_bandwidth function should also change > to time_after, or just ignore this disunion? Let's just ignore them. You are very careful and I like it. Please move on and keep up the good work! Thanks, Fengguang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/