Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756138Ab2FJO4u (ORCPT ); Sun, 10 Jun 2012 10:56:50 -0400 Received: from mail-yw0-f46.google.com ([209.85.213.46]:63952 "EHLO mail-yw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751780Ab2FJO4t convert rfc822-to-8bit (ORCPT ); Sun, 10 Jun 2012 10:56:49 -0400 MIME-Version: 1.0 X-Originating-IP: [89.139.19.137] In-Reply-To: <1338989907-25360-5-git-send-email-sjur.brandeland@stericsson.com> References: <1338989907-25360-1-git-send-email-sjur.brandeland@stericsson.com> <1338989907-25360-5-git-send-email-sjur.brandeland@stericsson.com> From: Ohad Ben-Cohen Date: Sun, 10 Jun 2012 17:56:28 +0300 Message-ID: Subject: Re: [PATCH 4/7] remoteproc: Assign boot_addr in a separate function To: sjur.brandeland@stericsson.com Cc: Loic PALLARDY , Ludovic BARRE , linux-kernel@vger.kernel.org, Linus Walleij , =?ISO-8859-1?Q?Sjur_Br=E6ndeland?= Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 926 Lines: 27 On Wed, Jun 6, 2012 at 4:38 PM, wrote: > +/** > + * rproc_set_boot_addr() - Set rproc's boot address. > + * @rproc: remote processor which needs boot address set. > + * @fw: the ?the ELF firmware image typo: s/the the/the/ > - ? ? ? rproc->bootaddr = ehdr->e_entry; > + ? ? ? rproc_set_boot_addr(rproc, fw); We might want to do this a little bit differently, something like: rproc->bootaddr = rproc_get_boot_addr(rproc, fw); This way the binary-format-specific handler really only retrieves the boot address, without manipulating the framework's rproc structure. If such handler doesn't exist, a default zero can be returned. Thanks, Ohad. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/