Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754271Ab2FJRgz (ORCPT ); Sun, 10 Jun 2012 13:36:55 -0400 Received: from netrider.rowland.org ([192.131.102.5]:47460 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753872Ab2FJRgx (ORCPT ); Sun, 10 Jun 2012 13:36:53 -0400 Date: Sun, 10 Jun 2012 13:36:53 -0400 (EDT) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: Namjae Jeon cc: James.Bottomley@HansenPartnership.com, , , , , , , , Namjae Jeon , Pankaj Kumar , Amit Sahrawat Subject: Re: [PATCH v3 2/4] usb: storage: add support for write cache quirk on usb hdd In-Reply-To: <1339291826-2547-1-git-send-email-linkinjeon@gmail.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1022 Lines: 27 On Sat, 9 Jun 2012, Namjae Jeon wrote: > Add support for write cache quirk on usb hdd. scsi driver will be set to wce > by detecting write cache quirk in quirk list when plugging usb hdd. > --- a/include/linux/usb_usual.h > +++ b/include/linux/usb_usual.h > @@ -64,7 +64,9 @@ > US_FLAG(NO_READ_CAPACITY_16, 0x00080000) \ > /* cannot handle READ_CAPACITY_16 */ \ > US_FLAG(INITIAL_READ10, 0x00100000) \ > - /* Initial READ(10) (and others) must be retried */ > + /* Initial READ(10) (and others) must be retried */ \ > + US_FLAG(WRITE_CACHE, 0x00200000) \ > + /* Write Cache status is not available */ The documentation for the new flag should be added in the same patch along with the flag itself. There's no reason to have separate patches. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/