Message-ID: <1339400404.3963.7.camel@fourier.local.igalia.com>
Subject: Re: [PATCH] Staging: ipack: remove pr_fmt definition.
From: Samuel Iglesias =?ISO-8859-1?Q?Gons=E1lvez?= 
	<siglesias@igalia.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Date: Mon, 11 Jun 2012 09:40:04 +0200
In-Reply-To: <20120611072736.GI13539@mwanda>
References: <1339397797-17399-1-git-send-email-siglesias@igalia.com>
	 <20120611072500.GT4400@mwanda> <20120611072736.GI13539@mwanda>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1017
Lines: 27

On Mon, 2012-06-11 at 10:27 +0300, Dan Carpenter wrote:
> On Mon, Jun 11, 2012 at 10:25:00AM +0300, Dan Carpenter wrote:
> > On Mon, Jun 11, 2012 at 08:56:36AM +0200, Samuel Iglesias Gonsalvez wrote:
> > > As there is no pr_* function used here, pr_fmt is not needed.
> > > 
> > 
> > Nah.  What about if we decide to add some?  Also there are actually
> > a couple pr_err() calls in there already.
> 
> Oops.  Sorry my tree is old.  We removed the two calls to pr_err().

Same mistake here. In greg's staging-next the pr_err calls are not
present so the patch is totally valid but in linus branch they are there
(this is the reason of my error).

So, this patch is valid, unless we want the pr_fmt definition for the
future. However, I prefer to delete it.

Cheers,

Sam

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/