Date: Mon, 11 Jun 2012 11:08:52 -0300
From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Namhyung Kim <namhyung@gmail.com>
Cc: Dmitry Antipov <dmitry.antipov@linaro.org>, Ingo Molnar <mingo@redhat.com>,
        Paul Mackerras <paulus@samba.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>, linux-kernel@vger.kernel.org,
        linaro-dev@lists.linaro.org, patches@linaro.org
Subject: Re: [PATCH] perf sched replay: fix event lookup
Message-ID: <20120611140852.GB2202@infradead.org>
References: <1339232758-920-1-git-send-email-dmitry.antipov@linaro.org>
 <87pq96pfj9.fsf@sejong.aot.lge.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87pq96pfj9.fsf@sejong.aot.lge.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1182
Lines: 27

Em Mon, Jun 11, 2012 at 02:46:02PM +0900, Namhyung Kim escreveu:
> On Sat,  9 Jun 2012 13:05:58 +0400, Dmitry Antipov wrote:
> > Use new function trace_find_event_by_name to lookup events before
> > looking through /sys files. This helps 'perf sched replay' to map
> > event names to IDs correctly when processing perf.data recorded
> > on another machine.
> 
> Basically the same approach with the previous reply, please put this
> into trace_event__id(). And minor nits below..

Well, trace_event__id() is private to evlist and evlist so far is a
local thing, i.e. it doesn't know anything about perf.data files.

So I think we should have a per perf.data (perf_session) method that
knows that it shouldn't look _at all_ to /sys, but just at what came in
the perf.data file.

As well when we want something that is on the running machine, even if
we're dealing somehow with a perf.data file, we shouldn't use what is in
it.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/