Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755212Ab2FKQ3L (ORCPT ); Mon, 11 Jun 2012 12:29:11 -0400 Received: from mail-ob0-f174.google.com ([209.85.214.174]:57796 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754779Ab2FKQ3H (ORCPT ); Mon, 11 Jun 2012 12:29:07 -0400 MIME-Version: 1.0 In-Reply-To: <20120611035005.GC10170@linux-sh.org> References: <1339229611-2326-1-git-send-email-elezegarcia@gmail.com> <20120609091426.GA10170@linux-sh.org> <20120611035005.GC10170@linux-sh.org> Date: Mon, 11 Jun 2012 13:29:07 -0300 Message-ID: Subject: Re: [PATCH 1/6] sh: fix compiler warning by properly inlining flat_set_persistent() From: Ezequiel Garcia To: Paul Mundt Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-sh@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1664 Lines: 40 On Mon, Jun 11, 2012 at 12:50 AM, Paul Mundt wrote: > On Sun, Jun 10, 2012 at 06:33:10PM -0300, Ezequiel Garcia wrote: >> On Sat, Jun 9, 2012 at 6:14 AM, Paul Mundt wrote: >> > On Sat, Jun 09, 2012 at 05:13:26AM -0300, Ezequiel Garcia wrote: >> >> This patch removes the following warning: >> >> fs/binfmt_flat.c:752: warning: unused variable ???persistent??? >> >> There is neither change in functionality, nor extra code generated. >> >> >> >> Cc: Paul Mundt >> >> Cc: >> >> Signed-off-by: Ezequiel Garcia >> > >> > That's what the cast was for, with what gcc version did that stop >> > working? >> >> I just realized that I should send a v2 (not the whole series just this one) >> correcting the commit message, since there wasn't a warning to fix >> in first place. >> >> I'll do this soon. > > If there's no warning then the point of the patch eludes me. There's > nothing wrong with consistency, but attempting to fix that which isn't > broken in the name of consistency borders a bit too closely on pointless > busy work for my liking. If you feel like that, then it's perfectly fine with me. As I already told you, I was going to propagate your magical define to the rest of arches, but the inline looked a bit more readable. Sorry for the noise and thanks for your time. Regards, Ezequiel. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/