Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751980Ab2FKRdr (ORCPT ); Mon, 11 Jun 2012 13:33:47 -0400 Received: from mail-vc0-f174.google.com ([209.85.220.174]:56926 "EHLO mail-vc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751257Ab2FKRdq (ORCPT ); Mon, 11 Jun 2012 13:33:46 -0400 MIME-Version: 1.0 In-Reply-To: <4FD4DC26.5080902@acm.org> References: <4FD345DC.6020405@acm.org> <4FD4DC26.5080902@acm.org> Date: Mon, 11 Jun 2012 10:33:45 -0700 Message-ID: Subject: Re: [PATCH UPDATED] block: In blk_execute_rq_nowait, init rq->end_io before checking for dead queue. From: Muthu Kumar To: Bart Van Assche Cc: Jens Axboe , Tejun Heo , Jej B , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 782 Lines: 22 On Sun, Jun 10, 2012 at 10:40 AM, Bart Van Assche wrote: > On 06/09/12 23:57, Muthu Kumar wrote: > >> Locking change is the one you posted already (the link above). Anyway, >> I have the attached patch *including* the locking change. Original >> mail has attachment without locking change. Please use whatever you >> need. > > > While we are at it ... the rq->rq_disk and rq->end_io assignments can be > performed safely before the spinlock is taken, isn't it ? > Yes.. that spinlock is to protect the q. > Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/