Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751521Ab2FKUtG (ORCPT ); Mon, 11 Jun 2012 16:49:06 -0400 Received: from mail-gg0-f174.google.com ([209.85.161.174]:53352 "EHLO mail-gg0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751110Ab2FKUtF (ORCPT ); Mon, 11 Jun 2012 16:49:05 -0400 MIME-Version: 1.0 In-Reply-To: References: <1339422650-9798-1-git-send-email-kosaki.motohiro@gmail.com> <4FD60127.1000805@jp.fujitsu.com> From: KOSAKI Motohiro Date: Mon, 11 Jun 2012 16:48:43 -0400 X-Google-Sender-Auth: CWR9jGXGogYwwTx_DfAyUUKfsGM Message-ID: Subject: Re: [PATCH] mm: fix protection column misplacing in /proc/zoneinfo To: David Rientjes Cc: cl@linux.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1086 Lines: 26 On Mon, Jun 11, 2012 at 4:37 PM, David Rientjes wrote: > On Mon, 11 Jun 2012, KOSAKI Motohiro wrote: > >> > You are not worried about breaking something that may scan the zoneinfo >> > output with this change? Its been this way for 6 years and its likely that >> > tools expect the current layout. >> >> I don't worry about this. Because of, /proc/zoneinfo is cray machine unfrinedly >> format and afaik no application uses it. >> > > We do, and I think it would be a shame to break anything parsing the way > that this file has been written for the past several years for something > as aesthetical as this. How do you parsing? Several years, some one added ZVC stat. therefore, hardcoded line number parsing never work anyway. And in the other hand, if you are parsing, field name, my patch doesn't break anything. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/