Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751777Ab2FKUw5 (ORCPT ); Mon, 11 Jun 2012 16:52:57 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:62477 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750985Ab2FKUw4 (ORCPT ); Mon, 11 Jun 2012 16:52:56 -0400 Date: Mon, 11 Jun 2012 13:52:54 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: KOSAKI Motohiro cc: cl@linux.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm: fix protection column misplacing in /proc/zoneinfo In-Reply-To: Message-ID: References: <1339422650-9798-1-git-send-email-kosaki.motohiro@gmail.com> <4FD60127.1000805@jp.fujitsu.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1035 Lines: 24 On Mon, 11 Jun 2012, KOSAKI Motohiro wrote: > > We do, and I think it would be a shame to break anything parsing the way > > that this file has been written for the past several years for something > > as aesthetical as this. > > How do you parsing? > > Several years, some one added ZVC stat. therefore, hardcoded line > number parsing never work anyway. And in the other hand, if you are > parsing, field > name, my patch doesn't break anything. > Yeah, your patch doesn't break me because I'm parsing by field name but I feel it would be a shame for it to break anyone else that may not be doing it that way. The set of users in the world who are parsing /proc/zoneinfo who may or may not do crazy things is not fully represented on this thread, so I don't feel it's worth it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/