Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752894Ab2FKXpJ (ORCPT ); Mon, 11 Jun 2012 19:45:09 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:46962 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751069Ab2FKXpI (ORCPT ); Mon, 11 Jun 2012 19:45:08 -0400 Date: Mon, 11 Jun 2012 16:45:07 -0700 (PDT) Message-Id: <20120611.164507.1289803990715626884.davem@davemloft.net> To: shaw500@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][RESEND] net: socket: Fixed some style issues and condensed list of fixes. From: David Miller In-Reply-To: <1339444359-16248-1-git-send-email-shaw500@gmail.com> References: <1339444359-16248-1-git-send-email-shaw500@gmail.com> X-Mailer: Mew version 6.5 on Emacs 23.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1036 Lines: 25 From: Matthew Shaw Date: Mon, 11 Jun 2012 20:52:39 +0100 > From: Matthew Shaw > > There was an instance of brackets in an if statement that was not > required, and a number of lines that exceeded 80 chars. The fixes > list has also been condensed to simply list the people that should > be credited with various fixes in net/socket.c throughout its > developement. > > Signed-off-by: Matthew Shaw I don't see any value in this patch, and the comment fixups don't use the recommended coding style in the networking, you would need to get rid of all of that extraneous whitespace between "/* ", "* ", and the actual test. But again I really see no value to this change, so I won't be applying a patch like this, in any form. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/