Date: Mon, 11 Jun 2012 16:56:57 -0700
From: Greg KH <gregkh@linuxfoundation.org>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>, devel@driverdev.osuosl.org,
        fmhess@users.sourceforge.net, abbotti@mev.co.uk
Subject: Re: [PATCH] staging: comedi: cleanup alloc_subdevices
Message-ID: <20120611235657.GA26721@kroah.com>
References: <201206071508.15674.hartleys@visionengravers.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201206071508.15674.hartleys@visionengravers.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1691
Lines: 42

On Thu, Jun 07, 2012 at 03:08:15PM -0700, H Hartley Sweeten wrote:
> Cleanup the comedi core "alloc_subdevices" fuction and it's use
> in the comedi drivers.
> 
> 1) Move the inline alloc_subdevices() function from comedidev.h
> to drivers.c and rename it to comedi_alloc_subdevices(). The
> function is large enough to warrant being an exported symbol
> rather than being an inline in every driver.
> 
> 2) Since dev->n_subdevices is an int variable, change the 
> num_subdevices parameter from an unsigned int to an int.
> 
> 3) It's possible for a couple of the comedi drivers to incorrectly
> call this function with num_subdevices = 0 so add a sanity check
> before doing the kcalloc.
> 
> 4) It's possible for the kcalloc to fail so don't set dev->n_subdevices
> until after the kcalloc has succedded. Also, remove the places in
> the drivers were dev->n_subdevices was being set directly.
> 
> 5) Remove all the "allocation failed" error messages.
> 
> 6) Remove all the "Allocate the subdevice structures" comments from
> the drivers. The function name itself provides this information.
> 
> 7) When comedi_alloc_subdevices does fail, make all the drivers
> properly return the error code.

You are doing 7 different things in one patch.  Doesn't that imply that
you should have 7 different patches, in series, doing this?  That would
make it easier to review at the least.

Please redo this in that manner and resend.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/