From: Seungwon Jeon <tgih.jun@samsung.com>
To: merez@codeaurora.org
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
        "'Chris Ball'" <cjb@laptop.org>,
        "'Subhash Jadavani'" <subhashj@codeaurora.org>,
        "'S, Venkatraman'" <svenkatr@ti.com>
References: <000601cd47ab$8ad77c50$a08674f0$%jun@samsung.com>
 <68ac9afd251593ab3df348a469a10adb.squirrel@www.codeaurora.org>
In-reply-to: <68ac9afd251593ab3df348a469a10adb.squirrel@www.codeaurora.org>
Subject: RE: [PATCH v7 1/3] mmc: core: Add packed command feature of eMMC4.5
Date: Tue, 12 Jun 2012 12:12:49 +0900
Message-id: <001a01cd4849$3f287180$bd795480$%jun@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=Windows-1252
Content-transfer-encoding: 7bit
Thread-index: Ac1IEIwNdfUrfWRGQKebimG3ZAiK0gAJ5H4Q
Content-language: ko
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1315
Lines: 38

Maya Erez <merez@codeaurora.org> wrote:
> > +	if ((host->caps2 & MMC_CAP2_PACKED_CMD) &&
> > +			((card->ext_csd.max_packed_writes > 0) ||
> > +			(card->ext_csd.max_packed_reads > 0))) {
> > +		err = mmc_switch(card, EXT_CSD_CMD_SET_NORMAL,
> > +				EXT_CSD_EXP_EVENTS_CTRL,
> > +				EXT_CSD_PACKED_EVENT_EN,
> > +				card->ext_csd.generic_cmd6_time);
> > +		if (err && err != -EBADMSG)
> > +			goto free_card;
> 
> Subhash suggestion to change to the following is missing:
>      if (  (host->caps2 & MMC_CAP2_PACKED_WR &&
> card->ext_csd.max_packed_writes > 0) ||
>             (host->caps2 & MMC_CAP2_PACKED_RD &&
> card->ext_csd.max_packed_reads > 0)
Thanks to detect.
It'll be applied.

Best regards,
Seungwon Jeon

> 
> Thanks,
> Maya Erez
> Consultant for Qualcomm Innovation Center, Inc.
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/