Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752828Ab2FLLwf (ORCPT ); Tue, 12 Jun 2012 07:52:35 -0400 Received: from mga11.intel.com ([192.55.52.93]:34538 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752395Ab2FLLwW (ORCPT ); Tue, 12 Jun 2012 07:52:22 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.71,315,1320652800"; d="scan'208";a="164606181" Date: Tue, 12 Jun 2012 19:52:19 +0800 From: Fengguang Wu To: Wanpeng Li Cc: linux-kernel@vger.kernel.org, Gavin Shan Subject: Re: [PATCH v2] writeback: avoid race when update bandwidth Message-ID: <20120612115219.GA17348@localhost> References: <1339501561-4570-1-git-send-email-liwp.linux@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1339501561-4570-1-git-send-email-liwp.linux@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 933 Lines: 26 On Tue, Jun 12, 2012 at 07:46:01PM +0800, Wanpeng Li wrote: > From: Wanpeng Li > > "V1 -> V2" > * remove dirty_lock > > Since bdi->wb.list_lock is used to protect the b_* lists, > so the flushers who call wb_writeback to writeback pages will > stuck when bandwidth update policy holds this lock. In order > to avoid this race we can introduce a new bandwidth_lock who > is responsible for protecting bandwidth update policy. > > Signed-off-by: Wanpeng Li Applied with a new title "writeback: use a standalone lock for updating write bandwidth". "race" is sensitive because it often refers to some locking error. Thank you! Fengguang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/